[PATCH] staging: unisys: remove incorrect error handling after queue_delayed_work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The queue_delayed_work() return false if the work is
already on the queue, true otherwise.
So return value cannot be less than zero.

Signed-off-by: Daeseok Youn <daeseok.youn@xxxxxxxxx>
---
 .../unisys/visorchipset/visorchipset_main.c        |   14 ++++----------
 1 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset/visorchipset_main.c
index 400cb03..0dff759 100644
--- a/drivers/staging/unisys/visorchipset/visorchipset_main.c
+++ b/drivers/staging/unisys/visorchipset/visorchipset_main.c
@@ -2055,11 +2055,8 @@ Away:
 		}
 	}
 
-	if (queue_delayed_work(Periodic_controlvm_workqueue,
-			       &Periodic_controlvm_work, Poll_jiffies) < 0) {
-		LOGERR("queue_delayed_work failed!");
-		POSTCODE_LINUX_2(QUEUE_DELAYED_WORK_PC, POSTCODE_SEVERITY_ERR);
-	}
+	queue_delayed_work(Periodic_controlvm_workqueue,
+			   &Periodic_controlvm_work, Poll_jiffies);
 }
 
 static void
@@ -2193,11 +2190,8 @@ Away:
 
 	Poll_jiffies = POLLJIFFIES_CONTROLVMCHANNEL_SLOW;
 
-	if (queue_delayed_work(Periodic_controlvm_workqueue,
-			       &Periodic_controlvm_work, Poll_jiffies) < 0) {
-		LOGERR("queue_delayed_work failed!");
-		POSTCODE_LINUX_2(QUEUE_DELAYED_WORK_PC, POSTCODE_SEVERITY_ERR);
-	}
+	queue_delayed_work(Periodic_controlvm_workqueue,
+			   &Periodic_controlvm_work, Poll_jiffies);
 }
 
 static void
-- 
1.7.4.4


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux