On Fri, Mar 07, 2014 at 08:18:44AM -0600, Romer, Benjamin M wrote: > > On Thu, 2014-03-06 at 12:01 -0800, gregkh@xxxxxxxxxxxxxxxxxxx wrote: > > On Thu, Mar 06, 2014 at 10:01:04AM -0600, Romer, Benjamin M wrote: > > > This patch updates the MAINTAINERS file to add the maintainer for the > > > Unisys s-Par driver set. > > > > > > Signed-off-by: Ken Cox <jkc@xxxxxxxxxx> > > > signed-off-by: Ben Romer <sparmaintainer@xxxxxxxxxx> > > > > Please capitalize things properly. > > > > And your From: address does not match your "Signed-off-by:" line. Why > > are you trying to use an "alias" as a maintainer or a sign-off? We want > > a "real" address / name please, especially as it's obvious you have one :) > > > > thanks, > > > > greg k-h > > The email address I listed is a group address - I'll change the contents of the file > so they more accurately describe how we've set things up. The file is fine (I think). Signed-off-by is like signing a legal document. You should sign on your own behalf and not for a group of people. And if the Signed-off-by doesn't match your From then how do we know it's really you? regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
