>On Thursday, March 6, 2014 11:59 AM, Hartley Sweeten <HartleyS@xxxxxxxxxxxxxxxxxxx> wrote: >>On Thursday, March 06, 2014 12:26 AM, Chase Southwood wrote: >> >>This patch for hwdrv_apci1564.c fixes the register map defines for the >>digital input registers such that they are all the real offsets to each >>register, rather than a mix of real offsets and adders to those offsets. >> >>Signed-off-by: Chase Southwood <chase.southwood@xxxxxxxxx> >>--- >> .../comedi/drivers/addi-data/hwdrv_apci1564.c | 101 +++++++++------------ >> 1 file changed, 44 insertions(+), 57 deletions(-)> > >This one is incomplete and breaks the build. > > CC [M] drivers/staging/comedi/drivers/addi_apci_1564.o >In file included from drivers/staging/comedi/drivers/addi_apci_1564.c:11:0: >drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c: In function >'i_APCI1564_ConfigTimerCounterWatchdog': >drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:352:4: error: 'APCI1564_TCW_PROG' >undeclared (first use in this function) >drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:352:4: note: each undeclared identifier is >reported only once for each function it appears in >drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:359:4: error: 'APCI1564_TCW_RELOAD_VALUE' >undeclared (first use in this function) >drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c: In function >'i_APCI1564_StartStopWriteTimerCounterWatchdog': >drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:463:19: error: 'APCI1564_TCW_PROG' >undeclared (first use in this function) >drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c: In function >'i_APCI1564_ReadTimerCounterWatchdog': >drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:526:4: error: >'APCI1564_TCW_SYNC_ENABLEDISABLE' undeclared (first use in this function) >drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c:529:19: error: 'APCI1564_TCW_TRIG_STATUS' >undeclared (first use in this function) >make[4]: *** [drivers/staging/comedi/drivers/addi_apci_1564.o] Error 1 >make[3]: *** [drivers/staging/comedi/drivers] Error 2 >make[2]: *** [drivers/staging/comedi] Error 2 >make[1]: *** [drivers/staging] Error 2 >make: *** [drivers] Error 2 > >Be sure to do a build after each patch to make sure it works. Hartley, I'm sorry for this, it appears that this whole patch series was sloppy and quite untested by myself. I have made up a fixed patchset and have tested everything this time around, I trust that you should have a better time reviewing this one. I will not let this happen again in the future. Thanks, Chase > >Regards, >Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
