Re: staging: virthba driver to access shared SCSI hba

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 07, 2014 at 12:11:10AM +0300, Dan Carpenter wrote:
> Hello Ken Cox,
> 
> The patch dc95086172db: "staging: virthba driver to access shared
> SCSI hba" from Mar 4, 2014, leads to the following Sparse warning:
> 
> 	drivers/staging/unisys/virthba/virthba.c:1442:24: warning:
> 	Variable length array is used.
> 
> drivers/staging/unisys/virthba/virthba.c
>   1438  static ssize_t
>   1439  enable_ints_write(struct file *file, const char __user *buffer,
>   1440                    size_t count, loff_t *ppos)
>   1441  {
>   1442          char buf[count + 1];
>                          ^^^^^^^^^
> The kernel has an 8k stack for the whole call tree starting from the
> syscall.  Bugs like this could have pretty serious security
> implications.

Ugh, that's really serious.  Ken, please fix this one up as soon as
possible, I don't want broken code like this ending up in Linus's
tree.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux