Re: [PATCH 2/2] lustre/lov_obd: fix possible null pointer dereference

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 05, 2014 at 02:04:36PM +0100, Maxin B. John wrote:
> From: "Maxin B. John" <maxin.john@xxxxxxxx>
> 
> osc_obd can be NULL. cppcheck reported this:
> [lustre/lustre/lov/lov_obd.c:283]: (error) Possible null pointer dereference:
> osc_obd - otherwise it is redundant to check if osc_obd is null at line 295

Same problem, osc_obd can never be NULL, please be more careful with
your patches, and just remove pointless tests instead of papering over
them with patches like this.

thanks.

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux