Re: [PATCH 02/03] staging: dgap: fix a few more 80+ lines as reported by checkpatch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 06, 2014 at 02:26:17PM -0500, Mark Hounschell wrote:
> On 03/05/2014 04:47 PM, Dan Carpenter wrote:
> >On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:
> >>@@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty, const unsigned char *buf, int
> >>  		if (down_interruptible(&dgap_TmpWriteSem))
> >>  			return -EINTR;
> >>
> >>-		if (copy_from_user(dgap_TmpWriteBuf, (const uchar __user *) buf, count)) {
> >>+		if (copy_from_user(dgap_TmpWriteBuf, (const uchar __user *)buf,
> >>+					count)) {
> >>  			up(&dgap_TmpWriteSem);
> >>  			return -EFAULT;
> >>  		}
> >
> >This is dead code btw.  "from_user" is always false.
> >
> 
> Dan, can I assume Greg will pick this one up as is since this dead
> code is removed in a later patch?

Yes.  Yes.  Fine.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux