On 03/05/2014 04:47 PM, Dan Carpenter wrote:
On Wed, Mar 05, 2014 at 03:54:50PM -0500, Mark Hounschell wrote:@@ -2953,7 +2955,8 @@ static int dgap_tty_write(struct tty_struct *tty, const unsigned char *buf, int if (down_interruptible(&dgap_TmpWriteSem)) return -EINTR; - if (copy_from_user(dgap_TmpWriteBuf, (const uchar __user *) buf, count)) { + if (copy_from_user(dgap_TmpWriteBuf, (const uchar __user *)buf, + count)) { up(&dgap_TmpWriteSem); return -EFAULT; }This is dead code btw. "from_user" is always false.
Are you saying that copy_from_user can never return anything but 0? thanks mark _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
