On Thu, 2014-03-06 at 02:27 +0100, Laurent Pinchart wrote: > On Wednesday 05 March 2014 17:00:37 Joe Perches wrote: > > On Thu, 2014-03-06 at 01:48 +0100, Laurent Pinchart wrote: > > > Would you recommend to drop driver-specific Kconfig options related to > > > debugging and use CONFIG_DYNAMIC_DEBUG instead ? > > For development, sure, if there's sufficient memory. > > For embedded systems with limited memory, using dynamic_debug isn't always > > possible or effective. > > Also, there are sometimes reasons to have debugging messages always enabled > > or emitted. > > For those cases, either adding #define DEBUG or using printk(KERN_DEBUG > > would be fine. > My goal here is to offer an easy way for users to enable debugging without > requiring changes to the source code. Dynamic debugging works, but various distributions don't have it enabled. > The driver includes various dev_dbg() > messages, I don't want to ask people reporting problems to turn them into > printk() calls :-) Even adding #define DEBUG at the beginning of the source > files is likely too error prone for users without much programming experience. I think your best bet is to add #define DEBUG to a common header file like iss.h or omap4iss.h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
