Re: [PATCH 00/67 v2] staging: comedi: clenaup pcl812/816/818 drivers part 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2014-03-04 18:29, H Hartley Sweeten wrote:
This series continues the cleanup of the pcl812/816/818 drivers.

v2: address some issues pointed out by Ian Abbott
     * remove interrupt only command support from the pcl816 driver
     * reorder FIFO read in the pcl816 driver

H Hartley Sweeten (67):
   staging: comedi: pcl816: remove pcl816_check()
   staging: comedi: pcl818: remove pcl818_check()
   staging: comedi: pcl818: fix board resource region request
   staging: comedi: pcl812: remove 'ai_neverending' from private data
   staging: comedi: pcl816: remove 'ai_neverending' from private data
   staging: comedi: pcl818: remove 'neverending_ai' from private data
   staging: comedi: pcl812: factor out dma setup to helper functions
   staging: comedi: pcl816: factor out dma setup to helper functions
   staging: comedi: pcl818: factor out dma setup to helper functions
   staging: comedi: pcl812: remove 'ai_data_len' from private data
   staging: comedi: pcl816: remove 'dmasamplesize' from private data
   staging: comedi: pcl812: interrupt handlers should not busywait
   staging: comedi: pcl818: interrupt handlers should not busywait
   staging: comedi: pcl816: remove unreachable interrupt handler code
   staging: comedi: pcl816: only hook up async command support if DMA is available
   staging: comedi: pcl812: factor out the common "next ai chan" code
   staging: comedi: pcl816: factor out the "next ai chan" code
   staging: comedi: pcl818: factor out the common "next ai chan" code
   staging: comedi: pcl818: fix PCL818_FI_DATAHI
   staging: comedi: pcl818: introduce pcl818_ai_get_fifo_sample()
   staging: comedi: pcl818: factor out the common "dropout" detect code
   staging: comedi: pcl816: reduce indent level in pcl816_ai_cancel()
   staging: comedi: pcl818: reduce indent level in pcl818_ai_cancel()
   staging: comedi: pcl816: clarify 'irq_was_now_closed' flag in private data
   staging: comedi: pcl818: fix (*cancel) when cmd->stop_src == TRIG_NONE
   staging: comedi: pcl812: remove "spurious interrupt" noise
   staging: comedi: pcl816: exit interrupt quick when there is nothing to do
   staging: comedi: pcl818: exit interrupt quick when there is nothing to do
   staging: comedi: pcl816: remove 'int816_mode' from private data
   staging: comedi: pcl818: remove 'ai_mode' from private data
   staging: comedi: pcl812: consolidate the common interrupt code
   staging: comedi: pcl816: consolidate the interrupt code
   staging: comedi: pcl818: consolidate the common interrupt code
   staging: comedi: pcl812: tidy up the digital subdevices
   staging: comedi: pcl816: add support for digital subdevices
   staging: comedi: pcl818: tidy up the digital subdevices
   staging: comedi: pcl816: move pcl816_reset()
   staging: comedi: pcl812: tidy up the analog output subdevice
   staging: comedi: pcl818: tidy up the analog output subdevice
   staging: comedi: pcl818: tidy up the analog input (*insn_read)
   staging: comedi: pcl816: tidy up the analog input (*insn_read)
   staging: comedi: pcl812: tidy up the analog input (*insn_read)
   staging: comedi: pcl812: introduce pcl812_ai_clear_eoc()
   staging: comedi: pcl816: introduce pcl816_ai_clear_eoc()
   staging: comedi: pcl818: introduce pcl818_ai_clear_eoc()
   staging: comedi: pcl818: introduce pcl818_ai_soft_trig()
   staging: comedi: pcl816: introduce pcl816_ai_soft_trig()
   staging: comedi: pcl812: introduce pcl812_ai_soft_trig()
   staging: comedi: pcl812: tidy up analog input registers
   staging: comedi: pcl816: tidy up analog input registers
   staging: comedi: pcl818: tidy up analog input registers
   staging: comedi: pcl818: define the status register bits
   staging: comedi: pcl816: define the status register bits
   staging: comedi: pcl812: define the status register bits
   staging: comedi: pcl812: cleanup setup_range_channel()
   staging: comedi: pcl816: cleanup setup_channel_list()
   staging: comedi: pcl818: cleanup setup_channel_list()
   staging: comedi: pcl812: define the mode register bits
   staging: comedi: pcl816: define the mode register bits
   staging: comedi: pcl818: define the mode register bits
   staging: comedi: pcl818: absorb pcl818_ai_mode13dma_int()
   staging: comedi: pcl818: cleanup ai_cmd()
   staging: comedi: pcl812: tidy up the remaining register defines
   staging: comedi: pcl816: tidy up the remaining register defines
   staging: comedi: pcl818: tidy up the remaining register defines
   staging: comedi: pcl812: clarify pcl812_reset()
   staging: comedi: pcl818: clarify pcl818_reset()

  drivers/staging/comedi/drivers/pcl812.c |  711 +++++++++++-----------
  drivers/staging/comedi/drivers/pcl816.c |  639 +++++++++----------
  drivers/staging/comedi/drivers/pcl818.c | 1012 ++++++++++++++-----------------
  3 files changed, 1094 insertions(+), 1268 deletions(-)

I'm not going to go through them all again. The mapping of patches from v1 to v2 seems to be:

01..12 --> 01..12
13     --> 14..15
14     --> 13
15..66 --> 16..67

so I've looked at v2 patches 13..15 and 20 this time, assuming the remaining patches are identical to the original patches or rebased as a result of changes.

In that case:

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux