On Wed, Mar 05, 2014 at 12:42:59PM +0300, Dan Carpenter wrote: > On Tue, Mar 04, 2014 at 09:10:41PM +0200, Valentina Manea wrote: > > diff --git a/drivers/staging/usbip/userspace/libsrc/usbip_common.h b/drivers/staging/usbip/userspace/libsrc/usbip_common.h > > index 2cb81b3..565ac78 100644 > > --- a/drivers/staging/usbip/userspace/libsrc/usbip_common.h > > +++ b/drivers/staging/usbip/userspace/libsrc/usbip_common.h > > @@ -29,6 +29,15 @@ > > #define USBIP_HOST_DRV_NAME "usbip-host" > > #define USBIP_VHCI_DRV_NAME "vhci_hcd" > > > > +/* sysfs constants */ > > +#define SYSFS_MNT_PATH "/sys" > > +#define SYSFS_BUS_NAME "bus" > > +#define SYSFS_BUS_TYPE "usb" > > +#define SYSFS_DRIVERS_NAME "drivers" > > What on earth??? I don't even want to review any further than this. > > Groan.... No. no no no no no. > I overreacted. This stuff was already in the original code, and this change just moves it around. Fine fine. These patch set seem ok with me. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
