[PATCH 10/11 v2] staging: dgap: Fix printk related errors as reported by checkpatch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This patch fixes some printk related errors report by checkpatch.

Signed-off-by: Mark Hounschell <markh@xxxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
 drivers/staging/dgap/dgap.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index ff7bf2a..698655e 100644
--- a/drivers/staging/dgap/dgap.c
+++ b/drivers/staging/dgap/dgap.c
@@ -540,7 +540,7 @@ static int dgap_init_module(void)
 		if (dgap_NumBoards)
 			pci_unregister_driver(&dgap_driver);
 		else
-			printk("WARNING: dgap driver load failed.  No DGAP boards found.\n");
+			pr_err("dgap: driver load failed. No boards found.\n");
 
 		dgap_cleanup_module();
 	} else {
@@ -2945,7 +2945,6 @@ static int dgap_tty_write(struct tty_struct *tty, const unsigned char *buf, int
 
 		if (copy_from_user(dgap_TmpWriteBuf, (const uchar __user *) buf, count)) {
 			up(&dgap_TmpWriteSem);
-			printk("Write: Copy from user failed!\n");
 			return -EFAULT;
 		}
 
@@ -6686,7 +6685,6 @@ static void dgap_create_tty_sysfs(struct un_t *un, struct device *c)
 
 	ret = sysfs_create_group(&c->kobj, &dgap_tty_attribute_group);
 	if (ret) {
-		printk(KERN_ERR "dgap: failed to create sysfs tty device attributes.\n");
 		sysfs_remove_group(&c->kobj, &dgap_tty_attribute_group);
 		return;
 	}
@@ -7560,7 +7558,7 @@ static char *dgap_getword(char **in)
  */
 static void dgap_err(char *s)
 {
-	printk("DGAP: parse: %s\n", s);
+	pr_err("dgap: parse: %s\n", s);
 }
 
 /*
-- 
1.8.1.4

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux