On Mon, Mar 03, 2014 at 11:30:19AM -0600, Ken Cox wrote:
> +/* periodic_work.h
> + *
> + * Copyright © 2010 - 2013 UNISYS CORPORATION
> + * All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or (at
> + * your option) any later version.
I have to ask, do you really mean "any later version" here?
> +CHARQUEUE *charqueue_create(ulong nslots)
> +{
> + int alloc_size = sizeof(CHARQUEUE) + nslots + 1;
> + CHARQUEUE *cq = kmalloc(alloc_size, GFP_KERNEL|__GFP_NORETRY);
> + if (cq == NULL) {
> + ERRDRV("charqueue_create allocation failed (alloc_size=%d)",
> + alloc_size);
> + return NULL;
> + }
> + cq->alloc_size = alloc_size;
> + cq->nslots = nslots;
> + cq->head = cq->tail = 0;
> + spin_lock_init(&cq->lock);
> + return cq;
> +}
> +EXPORT_SYMBOL(charqueue_create);
For staging drivers, I really want to see EXPORT_SYMBOL_GPL() for the
exports for a variety of reasons dealing with historical issues...
Can you change all of these please?
And how "wed" are you to the proc interface, that is going to change,
right? What userspace tools rely on it and who is going to be
responsible for changing them as the user/kernel api changes with this
code?
thanks,
g
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
