On 2014-02-28 23:24, H Hartley Sweeten wrote:
The interrupt is only generated by the hardware at the completion of
an A/D conversion. Because of this the sanity check to make sure that
the A/D conversion is complete and data is available is probably
unnecessary but it doesn't hurt anything.
The busywait loop is a different issue. Interrupt routines should not
busywait. That's just mean...
Remove the bustwait and use pcl812_ai_eoc() to check for the end-of-
conversion.
tl;dr patch okay. The following is just a comment.
I don't know why the interrupt routine waited for the conversion to
complete. I could understand it if the interrupt was triggered at the
start of conversion (which would be pretty dumb), but from the somewhat
poor documentation, the interrupt does appear to happen at the end of
conversion.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
