On Sat, Mar 01, 2014 at 10:22:48PM -0700, Axel Rasmussen wrote:
> Signed-off-by: Axel Rasmussen <axel.rasmussen1@xxxxxxxxx>
> ---
> drivers/staging/rtl8187se/r8180_core.c | 73 ++++++++++++++++++++--------------
> 1 file changed, 44 insertions(+), 29 deletions(-)
>
> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
> index b6c8c00..cd22ba3 100644
> --- a/drivers/staging/rtl8187se/r8180_core.c
> +++ b/drivers/staging/rtl8187se/r8180_core.c
> @@ -1021,7 +1021,8 @@ inline u16 ieeerate2rtlrate(int rate)
> }
> }
>
> -static u16 rtl_rate[] = {10, 20, 55, 110, 60, 90, 120, 180, 240, 360, 480, 540, 720};
> +static u16 rtl_rate[] = {10, 20, 55, 110, 60,
> + 90, 120, 180, 240, 360, 480, 540, 720};
>
> inline u16 rtl8180_rate2rate(short rate)
> {
> @@ -1236,7 +1237,8 @@ static void rtl8180_rx(struct net_device *dev)
> tmp = priv->rxringtail;
> do {
> if (tmp == priv->rxring)
> - tmp = priv->rxring + (priv->rxringcount - 1)*rx_desc_size;
> + tmp = priv->rxring + (priv->rxringcount - 1) *
> + rx_desc_size;
> else
> tmp -= rx_desc_size;
>
> @@ -1322,21 +1324,26 @@ static void rtl8180_rx(struct net_device *dev)
> priv->rx_skb_complete = 1;
> }
>
> - signal = (unsigned char)(((*(priv->rxringtail+3)) & (0x00ff0000))>>16);
> + signal = (unsigned char)(*(priv->rxringtail + 3) &
> + 0x00ff0000) >> 16;
Nope. This introduces a bug.
I have not reviewed any further into this patch.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
