On Sat, 2014-03-01 at 22:22 -0700, Axel Rasmussen wrote:
> The definition of the driver's ChannelPlan array produced a large number
> of checkpatch.pl errors. This patch fixes all of them by adding spaces
> and wrapping the resulting overly-long lines.
I think the current code is better.
> diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
[]
> @@ -2242,17 +2242,44 @@ static void watch_dog_adaptive(unsigned long data)
[for instance]
> static struct rtl8187se_channel_list channel_plan_list[] = {
> - {{1,2,3,4,5,6,7,8,9,10,11,36,40,44,48,52,56,60,64},19}, /* FCC */
[]
> + /* FCC */
> + {{1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 36, 40,
> + 44, 48, 52, 56, 60, 64}, 19},
If you really do this, it may be better to
remove the len variable and test for != 0
instead of channel_plan_list[].len
So instead of:
drivers/staging/rtl8187se/r8180_core.c:
for (i = 0; i < channel_plan_list[channel_plan].len; i++) {
Maybe:
for (i = 0; channel_plan_list[channel_plan].channel[i]; i++) {
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
