On 02/28/2014 05:06 PM, Dan Carpenter wrote:
Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> Btw, for later work, this driver returns -EFAULT a lot when some times it should be returning -EINVAL or something. Also the DGAP_VERIFY_BOARD() macro is disgusting. regards, dan carpenter
Yes, the DGAP_VERIFY_BOARD() is disgusting. From what I read in CodingStyle, I should replace it with the actual code because of the returns in it?
The -EFAULT vs -EINVAL thing can be addressed later on once I understand the difference? Thanks Mark _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
