Please redo this one.
On Fri, Feb 28, 2014 at 03:48:58PM -0500, Mark Hounschell wrote:
> This patch fixes some printk related errors report by checkpatch.
> It also removes more Digi debug/trace code left behind from patch #1.
>
These are two separate patches. The debug code is dead code yes? Did
leaving this behind break anything or cause a bug? If so then we need
to redo #1. Shouldn't we remove it from the header file? Do we still
need the dgap_global_lock now? (If not then remove in a later patch).
> --- a/drivers/staging/dgap/dgap.c
> +++ b/drivers/staging/dgap/dgap.c
> @@ -542,7 +542,7 @@ static int dgap_init_module(void)
> if (dgap_NumBoards)
> pci_unregister_driver(&dgap_driver);
> else
> - printk("WARNING: dgap driver load failed. No DGAP boards found.\n");
> + pr_err("dgap: driver load failed. No boards found.\n");
>
dev_err().
> @@ -6064,7 +6036,7 @@ static void dgap_create_driver_sysfiles(struct pci_driver *dgap_driver)
> rc |= driver_create_file(driverfs, &driver_attr_pollcounter);
> rc |= driver_create_file(driverfs, &driver_attr_state);
> if (rc)
> - printk(KERN_ERR "DGAP: sysfs driver_create_file failed!\n");
> + pr_err("dgap: sysfs driver_create_file failed!\n");
Sysfs handles its own error messages. Delete all these sysfs printks.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
