On Fri, Feb 28, 2014 at 10:52:32AM +0300, Dan Carpenter wrote: > On Fri, Feb 28, 2014 at 01:31:20AM -0600, Chase Southwood wrote: > > hwdrv_apci1564.c had numerous lines over the column limit. This patch > > splits all such lines to bring them in compliance with coding style. > > > > Signed-off-by: Chase Southwood <chase.southwoo@xxxxxxxxx> > > --- > > .../comedi/drivers/addi-data/hwdrv_apci1564.c | 50 ++++++++++++++++------ > > 1 file changed, 36 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c > > index 2b47fa1..77030c5 100644 > > --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c > > +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1564.c > > @@ -324,11 +324,15 @@ static int i_APCI1564_ConfigTimerCounterWatchdog(struct comedi_device *dev, > > inl(devpriv->i_IobaseAmcc + APCI1564_TIMER + > > APCI1564_TCW_PROG); > > ul_Command1 = ul_Command1 & 0xFFFFF9FEUL; > > - outl(ul_Command1, devpriv->i_IobaseAmcc + APCI1564_TIMER + APCI1564_TCW_PROG); /* Stop The Timer */ > > + /* Stop The Timer */ > > + outl(ul_Command1, devpriv->i_IobaseAmcc + APCI1564_TIMER + > > + APCI1564_TCW_PROG); > > Just make a helper function so that you can call it like this: > > static void outl_1564_timer(struct addi_private *devpriv, unsigned int cmd, > unsigned int reg) > { > outl(cmd, devpriv->i_IobaseAmcc + APCI1564_TIMER, reg); ^^^ Should be "devpriv->i_IobaseAmcc + APCI1564_TIMER + reg" obviously. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel