>On Tuesday, February 25, 2014 3:56 AM, Ian Abbott <abbotti@xxxxxxxxx> wrote: >>On 2014-02-25 08:15, Chase Southwood wrote: >> The static variable ui_Command is as of right now being cleared to a >> value of zero between everytime that it writes to a port and then takes a >> new value from a port. Seems like this zeroing is unnecessary, so we can >> just remove these lines. > >The description is slightly wrong as the variable isn't static storage >class. > Oh, shoot, you're exactly right. I was looking at some other variables which are static when I was making this up and I got storage classes all mixed up. I'll fix up the description and send it off to Greg again as it hasn't been applied yet. >> >> Signed-off-by: Chase Southwood <chase.southwood@xxxxxxxxx> >> --- >> This sort of thing seems like a copy/paste sort of error to me, but there >> could as easily be some reason here that I'm missing that this is needed >> here. My first impression, however, was that this extra clearing is >> useless. > >Yes, the extra clearing was useless. There are also some useless >initializers for this variable and others. > >Fine, apart from the description. > >Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx> > >-- >-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- >-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
