On Mon, 2014-02-24 at 19:39 +1100, David Roddick wrote: > This is a patch to remove unneccessary space after function pointer name found with checkpatch.pl A few comments: Please wrap your commit message to 70 columns or so. There is 1 c in unnecessary. The "This is a patch to " bit isn't particularly useful in the commit log, neither is the "found with checkpatch.pl". > diff --git a/drivers/staging/comedi/drivers/poc.c b/drivers/staging/comedi/drivers/poc.c [] > @@ -36,15 +36,15 @@ Configuration options: [] > - int (*winsn) (struct comedi_device *, struct comedi_subdevice *, > + int (*winsn)(struct comedi_device *, struct comedi_subdevice *, > struct comedi_insn *, unsigned int *); Please wrap multi-line definitions lines like: int (*winsn)(struct comedi_device *, struct comedi_subdevice *, struct comedi_insn *, unsigned int *); Ideally, these arguments would have some descriptive names too. _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
