On Mon, Feb 24, 2014 at 09:51:35AM +0900, Daeseok Youn wrote: > >From 5e737e8211cd1f83488e484c088befc5feb755a9 Mon Sep 17 00:00:00 2001 > From: Daeseok Youn <daeseok.youn@xxxxxxxxx> > Date: Mon, 24 Feb 2014 09:17:41 +0900 > Subject: [PATCH] staging: ced401: remove redundant spin_unlock Don't send this header. We get everything from the email header. > > sparse says: > drivers/staging/ced1401/usb1401.c:1080:28: warning: > context imbalance in 'Handle1401Esc' - unexpected unlock > Your fix is correct, but the changelog is not good. These messages in Sparse are wrong over 80% of the time. So when I see one in a commit message I assume it is wrong. Add some more explanation to say why you removed the spin_unlock. Also "redundant" means "unnecessary" but sort of implies that it is harmless. Say something like: "staging: ced401: fix double unlock bug". regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
