Come on... :/ Don't randomly add a pointless kfree() to one error path when there are four later error paths in this function that don't have a kfree(). It just makes the code more difficult to understand for no reason. And we're not going to add a comment to every single error path either. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel