> -----Original Message----- > From: David Miller [mailto:davem@xxxxxxxxxxxxx] > Sent: Wednesday, February 19, 2014 4:23 PM > To: Haiyang Zhang > Cc: netdev@xxxxxxxxxxxxxxx; KY Srinivasan; olaf@xxxxxxxxx; > jasowang@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; driverdev- > devel@xxxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH net-next] hyperv: Add latest NetVSP versions to auto > negotiation > > From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > Date: Tue, 18 Feb 2014 12:28:54 -0800 > > > + u32 ver_list[] = {NVSP_PROTOCOL_VERSION_1, > NVSP_PROTOCOL_VERSION_2, > > + NVSP_PROTOCOL_VERSION_4, NVSP_PROTOCOL_VERSION_5}; > > Please put a space after "{" and before "}". > > > + int i, num_ver = 4; /* number of different NVSP versions */ > > + > > > > net_device = get_outbound_net_device(device); > > Please delete the extraneous empty line. > > > + for (i = num_ver - 1; i >= 0; i--) > > + if (negotiate_nvsp_ver(device, net_device, init_packet, > > + ver_list[i]) == 0) { > > This is not indented properly, "ver_list[i])" should begin precisely after the > openning parenthesis of the negotiate_nvsp_ver() function call. I have sent out a new patch with the suggested updates. Thanks, - Haiyang _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
