On Tue, Feb 18, 2014 at 12:06:51PM +0000, Ian Abbott wrote:
> On 2014-02-17 21:26, H Hartley Sweeten wrote:
> >These comedi drivers are all very similar so it made sense to clean them
> >up together.
> >
> >This series removes a bunch of the cruft in the drivers and reduces the
> >boardinfo and private data.
> >
> >H Hartley Sweeten (87):
> > staging: comedi: pcl812: convert boardinfo declaration to C99 format
> > staging: comedi: pcl816: convert boardinfo declaration to C99 format
> > staging: comedi: pcl818: convert boardinfo declaration to C99 format
> > staging: comedi: pcl812: remove 0/NULL initialzation in boardinfo
> > staging: comedi: pcl818: remove 0/NULL initialzation in boardinfo
> > staging: comedi: pcl812: remove 'io_range' from boardinfo
> > staging: comedi: pcl816: remove 'io_range' from boardinfo
> > staging: comedi: pcl818: remove 'io_range' from boardinfo
> > staging: comedi: pcl812: remove 'i8254_osc_base' from boardinfo
> > staging: comedi: pcl816: remove 'i8254_osc_base' from boardinfo
> > staging: comedi: pcl812: remove 'rangelist_ao' from boardinfo
> > staging: comedi: pcl816: remove 'rangelist_ao' from boardinfo
> > staging: comedi: pcl818: remove 'rangelist_ao' from boardinfo
> > staging: comedi: pcl812: clarify dma channel request in pcl812_attach()
> > staging: comedi: pcl816: clarify dma channel request in pcl816_attach()
> > staging: comedi: pcl818: clarify dma channel request in pcl818_attach()
> > staging: comedi: pcl812: rename 'haveMPC508' in boardinfo
> > staging: comedi: pcl818: change 'is_818' in boardinfo to a bit-field
> > staging: comedi: pcl812: tidy up digital subdevice boardinfo
> > staging: comedi: pcl818: all board types have digital inputs and outputs
> > staging: comedi: pcl816: all board types have digital inputs and outputs
> > staging: comedi: pcl812: factor analog input range selection out of (*attach)
> > staging: comedi: pcl818: factor analog input range selection out of (*attach)
> > staging: comedi: pcl812: all board types have analog inputs
> > staging: comedi: pcl816: all board types have 16 analog inputs
> > staging: comedi: pcl818: all board types have analog inputs
> > staging: comedi: pcl812: tidy up differential ai user option
> > staging: comedi: pcl816: remove 'n_ranges' from boardinfo
> > staging: comedi: pcl818: remove 'n_ranges' from boardinfo
> > staging: comedi: pcl816: remove 'ao_chanlist' from boardinfo
> > staging: comedi: pcl816: remove incorrect 'ai_chanlist' from boardinfo
> > staging: comedi: pcl816: remove 'ai_range_type' from boardinfo
> > staging: comedi: pcl816: remove 'ai_ns_min' from boardinfo
> > staging: comedi: pcl816: remove 'n_aochan' from boardinfo
> > staging: comedi: pcl816: clarify irq request in pcl816_attach()
> > staging: comedi: pcl818: clarify irq request in pcl818_attach()
> > staging: comedi: pcl818: remove 'ai_maxdata' from boardinfo
> > staging: comedi: pcl818: remove 'ao_maxdata' from boardinfo
> > staging: comedi: pcl812: remove 'ai_maxdata' from boardinfo
> > staging: comedi: pcl812: introduce pcl812_ai_get_sample()
> > staging: comedi: pcl816: introduce pcl816_ai_get_sample()
> > staging: comedi: pcl818: introduce pcl818_ai_get_sample()
> > staging: comedi: pcl812: remove 'ai_is16b' from private data
> > staging: comedi: pcl812: remove acl8216_ai_insn_read()
> > staging: comedi: pcl812: remove 'valid' from private data
> > staging: comedi: pcl812: remove 'ai_scans' from private data
> > staging: comedi: pcl816: remove 'ai_scans' from private data
> > staging: comedi: pcl818: remove 'ai_scans' from private data
> > staging: comedi: pcl812: remove 'ai_n_chan' from private data
> > staging: comedi: pcl816: remove 'ai_n_chan' from private data
> > staging: comedi: pcl818: remove 'ai_n_chan' from private data
> > staging: comedi: pcl812: remove 'ai_flags' from private data
> > staging: comedi: pcl818: remove 'ai_flags' from private data
> > staging: comedi: pcl812: tidy up dma buffer allocation
> > staging: comedi: pcl816: tidy up dma buffer allocation
> > staging: comedi: pcl818: tidy up dma buffer allocation
> > staging: comedi: pcl816: remove 'last_int_sub' from private data
> > staging: comedi: pcl818: remove 'last_int_sub' from private data
> > staging: comedi: pcl812: use 8253.h helpers
> > staging: comedi: pcl816: use 8253.h helpers
> > staging: comedi: pcl818: use 8253.h helpers
> > staging: comedi: pcl816: remove unneeded forward declarations
> > staging: comedi: pcl812: don't calc the timer divisors twice
> > staging: comedi: pcl816: don't calc the timer divisors twice
> > staging: comedi: pcl818: don't calc the timer divisors twice
> > staging: comedi: pcl812: use subdevice (*cancel)
> > staging: comedi: pcl816: use subdevice (*cancel)
> > staging: comedi: pcl818: use subdevice (*cancel)
> > staging: comedi: pcl818: remove analog output interrupt code
> > staging: comedi: pcl818: remove 'ai_timer[12]' from private data
> > staging: comedi: pcl812: remove 'ai_chanlist' from private data
> > staging: comedi: pcl818: remove 'ai_chanlist' from private data
> > staging: comedi: pcl816: remove 'ai_act_chanlist_{len,pos}' from private data
> > staging: comedi: pcl812: convert private data flags to bit-fields
> > staging: comedi: pcl816: convert private data flags to bit-fields
> > staging: comedi: pcl818: convert private data flags to bit-fields
> > staging: comedi: pcl816: rename 'irq_blocked' in private data
> > staging: comedi: pcl818: rename 'irq_blocked' in private data
> > staging: comedi: pcl816: remove unnecessary 'dev->irq' check
> > staging: comedi: pcl812: remove unnecessary function separation comments
> > staging: comedi: pcl816: remove unnecessary function separation comments
> > staging: comedi: pcl818: remove unnecessary function separation comments
> > staging: comedi: pcl818: tidy up pcl818_check()
> > staging: comedi: pcl816: tidy up pcl818_check()
> > staging: comedi: pcl812: allocate private data before requesting the I/O region
> > staging: comedi: pcl816: kzalloc'ed memory does not need to be cleared
> > staging: comedi: pcl818: kzalloc'ed memory does not need to be cleared
> >
> > drivers/staging/comedi/drivers/pcl812.c | 873 ++++++++++++++++----------------
> > drivers/staging/comedi/drivers/pcl816.c | 528 +++++++------------
> > drivers/staging/comedi/drivers/pcl818.c | 710 +++++++++++---------------
> > 3 files changed, 911 insertions(+), 1200 deletions(-)
> >
>
> I don't agree with patch 31 (staging: comedi: pcl816: remove incorrect
> 'ai_chanlist' from boardinfo). I don't think dropping that patch has any
> knock-on effects on the other patches.
Yes, it caused others to not be able to be applied.
I've applied everything here, except patches:
33, 34, 35, 64, 67, 73, 75, 77, 79, 81, 84, and 86
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
