On 02/13/2014 11:04 PM, Haiyang Zhang wrote: > >> -----Original Message----- >> From: Jason Wang [mailto:jasowang@xxxxxxxxxx] >> Sent: Wednesday, February 12, 2014 10:52 PM >> To: Haiyang Zhang; davem@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx >> Cc: KY Srinivasan; olaf@xxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; driverdev- >> devel@xxxxxxxxxxxxxxxxxxxxxx >> Subject: Re: [PATCH net,v3] hyperv: Fix the carrier status setting >> >> On 02/13/2014 08:54 AM, Haiyang Zhang wrote: >>> Without this patch, the "cat /sys/class/net/ethN/operstate" shows >>> "unknown", and "ethtool ethN" shows "Link detected: yes", when VM >>> boots up with or without vNIC connected. >>> >>> This patch fixed the problem. >>> >>> Signed-off-by: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> >>> Reviewed-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> >>> --- >>> drivers/net/hyperv/netvsc_drv.c | 53 >> ++++++++++++++++++++++++++++----------- >>> 1 files changed, 38 insertions(+), 15 deletions(-) >>> >>> diff --git a/drivers/net/hyperv/netvsc_drv.c >>> b/drivers/net/hyperv/netvsc_drv.c index 7756118..7141a19 100644 >>> --- a/drivers/net/hyperv/netvsc_drv.c >>> +++ b/drivers/net/hyperv/netvsc_drv.c >>> @@ -88,8 +88,12 @@ static int netvsc_open(struct net_device *net) { >>> struct net_device_context *net_device_ctx = netdev_priv(net); >>> struct hv_device *device_obj = net_device_ctx->device_ctx; >>> + struct netvsc_device *nvdev; >>> + struct rndis_device *rdev; >>> int ret = 0; >>> >>> + netif_carrier_off(net); >>> + >>> /* Open up the device */ >>> ret = rndis_filter_open(device_obj); >>> if (ret != 0) { >>> @@ -99,6 +103,11 @@ static int netvsc_open(struct net_device *net) >>> >>> netif_start_queue(net); >>> >>> + nvdev = hv_get_drvdata(device_obj); >>> + rdev = nvdev->extension; >>> + if (!rdev->link_state) >>> + netif_carrier_on(net); >>> + >> Maybe you can just schedule the work here and then you can drop the >> rtnl_lock in netvsc_link_change() ? > The rtnl_lock will still be necessary in the netvsc_link_change(), because > we want to prevent it getting wrong rdev pointer when netvsc_change_mtu > is removing/adding rndis device. Ok. >>> + >>> + if (notify) >>> + netdev_notify_peers(net); >>> } >>> >> Looks like this forces arp_notify here. Is it expected? > Yes, this is expected. It's required after live migration. > > Thanks, > - Haiyang Yes, this does not change the current behaviour. (arp_notify is meaningless for netvsc). Acked-by: Jason Wang <jasowang@xxxxxxxxxx> The patch is also needed for stable. Thanks > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
