Greg mentioned doing the checkpatch.pl fixes later and that applies here as well. Leave the LINUX_VERSION_CODE code in for now and delete it in a later patch. On the other hand, I don't want to give you a lot of extra work to do if no one else cares... What I'm saying is that when you do moves, please *just* move the code exactly as unmodified as possible. I have tools to review that the code just shifted but was not modified. The truth is that when I review patches, I always pretend submitters work for the US government to sabotage things and insert backdoors. I want to verify that the patch does exactly what it says and nothing more. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel