RE: [PATCH 34/47 v2] staging: comedi: icp_multi: use comedi_timeout()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday, February 12, 2014 10:15 AM, Greg KH wrote:
> On Mon, Feb 10, 2014 at 11:49:33AM -0700, H Hartley Sweeten wrote:
>> Use comedi_timeout() to wait for the analog input and output end-of-
>> conversion.
>> 
>> Use break to exit the loop when a timeout occurs during the analog
>> input read so that common code can be used to disable the device.

<snip>

> How come these writew() calls are removed?  Don't we still need to do
> them in failure mode?

The break causes the common exit code to be used to disable the interrupt
and clear the interrupt status when a timeout occurs.

Regards,
Hartley

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux