Re: [PATCH 1/2] drivers:staging:silicom Fixed extern warnings reported by checkpatch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 11, 2014 at 11:57:22PM -0800, Surendra Patil wrote:
> 1) Deleted  bp_proc_create() declaration from bp_mod.h,
> because it is declared as static in bpctl_mod.c and not used anywhere.
> 
> 2) checkpatch warns about
>      WARNING: externs should be avoided in .c files
> 
> because we have function declarations in bptcl_mod.c,These
> functions are not used anywhere else so made them static.
> 
> Signed-off-by: Surendra Patil <surendra.tux@xxxxxxxxx>

Great.  :)  Thanks.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux