On Wed, Feb 12, 2014 at 5:22 AM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Sat, Feb 08, 2014 at 11:59:41AM +0900, SeongJae Park wrote:
>> Remove constant BINDER_SET_IDLE_PRIORITY because it is not used from
>> anywhere.
>
>>
>> Signed-off-by: SeongJae Park <sj38.park@xxxxxxxxx>
>> ---
>> drivers/staging/android/binder.h | 7 +++----
>> 1 file changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/android/binder.h b/drivers/staging/android/binder.h
>> index c4c1ed6..6d08e61 100644
>> --- a/drivers/staging/android/binder.h
>> +++ b/drivers/staging/android/binder.h
>> @@ -87,10 +87,9 @@ struct binder_version {
>> #define BINDER_WRITE_READ _IOWR('b', 1, struct binder_write_read)
>> #define BINDER_SET_IDLE_TIMEOUT _IOW('b', 3, __s64)
>> #define BINDER_SET_MAX_THREADS _IOW('b', 5, __u32)
>> -#define BINDER_SET_IDLE_PRIORITY _IOW('b', 6, __s32)
>> -#define BINDER_SET_CONTEXT_MGR _IOW('b', 7, __s32)
>> -#define BINDER_THREAD_EXIT _IOW('b', 8, __s32)
>> -#define BINDER_VERSION _IOWR('b', 9, struct binder_version)
>> +#define BINDER_SET_CONTEXT_MGR _IOW('b', 6, __s32)
>> +#define BINDER_THREAD_EXIT _IOW('b', 7, __s32)
>> +#define BINDER_VERSION _IOWR('b', 8, struct binder_version)
>
> And you just broke all userspace code that uses this interface :(
>
> Please be more careful, and test your patches properly.
Definitely my fault... Sorry.
I will be more careful and will not do such mistake again.
>
> greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
