Re: [PATCH 1/2] drivers:staging:rtl8821ae: Fixed few coding style erors and warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 09, 2014 at 10:55:25AM -0600, Larry Finger wrote:
> On 02/09/2014 01:30 AM, Surendra Patil wrote:
> >Fixed multiple coding style errors and warnings
> >wifi.h:1077: WARNING: please, no space before tabs
> >wifi.h:762: WARNING: missing space after struct definition
> >wifi.h:972: WARNING: please, no spaces at the start of a line
> >wifi.h:1825: WARNING: Unnecessary space after function pointer name
> >wifi.h:1826: ERROR: "foo * bar" should be "foo *bar"
> >wifi.h:1099: WARNING: missing space after return type
> >wifi.h:1320: ERROR: Macros with complex values should be enclosed in parenthesis
> >wifi.h:1758: WARNING: Multiple spaces after return type
> >wifi.h:1855: ERROR: code indent should use tabs where possible
> >wifi.h:2303: ERROR: space prohibited after that open parenthesis '('
> >wifi.h:2408: ERROR: spaces required around that '=' (ctx:VxV)
> >
> >Signed-off-by: Surendra Patil <surendra.tux@xxxxxxxxx>
> 
> You are free to hack on this driver as much as you want, but please be aware
> that this driver is only in staging on a temporary basis. I already have
> cleaned up the checkpatch errors on my version, and merged it with the
> version of rtlwifi that is in the wireless-testing tree. Once I obtain one
> of these devices and can test that the device actually works, it will be
> submitted to the drivers/net/wireless tree of the regular kernel, and it
> should be there by 3.15.

Please let me know when your version goes into the networking tree, so
I'll know to drop this version from linux-next to keep from people doing
unneeded cleanups.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux