[PATCH 0/9] staging: comedi: remove some async command cruft

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The comedi core always calls the subdevice (*do_cmdtest) to validata the
async command before it calls the (*do_cmd) to actually execute the command.

Since the (*do_cmdtest) has already validataed the command, any duplicate
tests in the (*do_cmd) are unnecessary. Remove them.

Also, the cb_das16_cs driver has a (*do_cmdtest) but it's (*do_cmd) just
returns -EINVAL and the interrupt handler does nothing. Remove the async
command support from this driver.

H Hartley Sweeten (9):
  staging: comedi: usbduxfast: 'cmd->chanlist_len' was already validataed
  staging: comedi: usbduxfast: remove TRIG_TIMER from scan_begin_src
  staging: comedi: adl_pci9111: trigger sources are validated in (*do_cmdtest)
  staging: comedi: cb_das16_cs: remove incomplete async command support
  staging: comedi: cb_pcidas: trigger sources are validated in (*do_cmdtest)
  staging: comedi: comedi_test: trigger sources are validated in (*do_cmdtest)
  staging: comedi: das800: trigger sources are validated in (*do_cmdtest)
  staging: comedi: pcl812: trigger sources were validated in (*do_cmdtest)
  staging: comedi: pcl816: trigger sources were validated in (*do_cmdtest)

 drivers/staging/comedi/drivers/adl_pci9111.c |  28 +-----
 drivers/staging/comedi/drivers/cb_das16_cs.c | 124 ---------------------------
 drivers/staging/comedi/drivers/cb_pcidas.c   |   7 +-
 drivers/staging/comedi/drivers/comedi_test.c |   6 +-
 drivers/staging/comedi/drivers/das800.c      |  17 +---
 drivers/staging/comedi/drivers/pcl812.c      |  18 ----
 drivers/staging/comedi/drivers/pcl816.c      |   9 --
 drivers/staging/comedi/drivers/usbduxfast.c  |  51 +++++------
 8 files changed, 30 insertions(+), 230 deletions(-)

-- 
1.8.5.2

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux