On Mon, Feb 10, 2014 at 12:18:42PM +0300, Dan Carpenter wrote: > On Sun, Feb 09, 2014 at 07:05:24PM -0800, Surendra Patil wrote: > > Fixed MACRO,Extern and parentheses Coding style warnings and errors - listed only few > > bpctl_mod.c:120: WARNING: externs should be avoided in .c files > > bpctl_mod.c:121: WARNING: externs should be avoided in .c files > > bpctl_mod.c:122: WARNING: externs should be avoided in .c files > > bpctl_mod.c:124: WARNING: externs should be avoided in .c files > > bpctl_mod.c:125: WARNING: externs should be avoided in .c files > > bp_ioctl.h:54: ERROR: Macros with complex values should be enclosed in parenthesis > > bp_ioctl.h:159: ERROR: Macros with complex values should be enclosed in p arenthesis > > bpctl_mod.c:1395: WARNING: Unnecessary parentheses - maybe == should be = ? > > > > These don't seem to match the patch at all. Oh. The patch does match. But it doesn't compile. bp_proc_create() is declared in the .h file. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
