OK. I will re-send this patch except replacing seq_printf() with seq_puts(). Your review helped me a lot. Thanks. Daeseok Youn. 2014-02-10 19:52 GMT+09:00 Dan Carpenter <dan.carpenter@xxxxxxxxxx>: > On Mon, Feb 10, 2014 at 07:23:46PM +0900, DaeSeok Youn wrote: >> Thanks for reviewing. >> >> Yes, I just followed by reports of checkpatch.pl. >> >> But I don't understand why I can use of seq_puts() in the middle of >> seq_printf() calls. >> I have been trying to search why that is not good but I didn't find >> anything about that. >> And I saw patches which were already merged similar with this patch. >> >> You can see with this url >> https://github.com/torvalds/linux/commit/2d219c518882d2b2bac77742a6a8979c9dad051a >> https://github.com/mirrors/linux-2.6/commit/7aff38176e79a22b1749c2af74060028298e6a45 >> >> If you don't mind, let me know why it is not good. > > Because it doesn't look nice. It messes up the alignment. > > Checkpatch is a tool not a king of the world. Stop obeying checkpatch. > > regards, > dan carpenter > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
