On 02/09/2014 01:30 AM, Surendra Patil wrote:
Fixed multiple coding style errors and warnings
wifi.h:1077: WARNING: please, no space before tabs
wifi.h:762: WARNING: missing space after struct definition
wifi.h:972: WARNING: please, no spaces at the start of a line
wifi.h:1825: WARNING: Unnecessary space after function pointer name
wifi.h:1826: ERROR: "foo * bar" should be "foo *bar"
wifi.h:1099: WARNING: missing space after return type
wifi.h:1320: ERROR: Macros with complex values should be enclosed in parenthesis
wifi.h:1758: WARNING: Multiple spaces after return type
wifi.h:1855: ERROR: code indent should use tabs where possible
wifi.h:2303: ERROR: space prohibited after that open parenthesis '('
wifi.h:2408: ERROR: spaces required around that '=' (ctx:VxV)
Signed-off-by: Surendra Patil <surendra.tux@xxxxxxxxx>
Are you sure that changing this one macro can fix all those errors and warnings?
I do not think so. Because the commit message is not appropriate, I must NACK
this patch; however, thanks for calling this macro to my attention. Surely it
should be replaced with a memcpy() call in the final version.
The starting items in the patch subject usually indicate the driver name. For
staging drivers, there is an additional mention of it. Thus the subject should
be "[PATCH 2/2] staging: rtl8821ae: Fixed .....". Where does that "vers:" come
from? If you mean "version", then any such information should be inside the "[]"
and after the PATCH.
Larry
---
drivers/staging/rtl8821ae/wifi.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8821ae/wifi.h b/drivers/staging/rtl8821ae/wifi.h
index 5ad95b8..1e830e8 100644
--- a/drivers/staging/rtl8821ae/wifi.h
+++ b/drivers/staging/rtl8821ae/wifi.h
@@ -2403,9 +2403,9 @@ Set subfield of little-endian 4-byte value to specified value. */
(_os).length = (_len);
#define CP_MACADDR(des,src) \
- ((des)[0] = (src)[0],(des)[1] = (src)[1],\
- (des)[2] = (src)[2],(des)[3] = (src)[3],\
- (des)[4] = (src)[4],(des)[5] = (src)[5])
+ ((des)[0] = (src)[0], (des)[1] = (src)[1],\
+ (des)[2] = (src)[2], (des)[3] = (src)[3],\
+ (des)[4] = (src)[4], (des)[5] = (src)[5])
static inline u8 rtl_read_byte(struct rtl_priv *rtlpriv, u32 addr)
{
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
