On Friday, February 07, 2014 8:34 AM, Ian Abbott wrote: > On 2014-02-06 23:49, H Hartley Sweeten wrote: >> Use comedi_timeout() to wait for the analog input end-of-conversion. >> >> Combine the logic for the pcl812 and acl812 end-of-conversion in the >> helper function to simplify the driver. >> >> The interrupt routine also uses the timeout check to make sure data >> is actually available. Using NULL here for the 'insn' is safe since >> nothing uses it. > > I don't think you can rely on jiffies being updated in the interrupt > routine. >From previous comments from Greg I assumed using jiffies for the timeout was ok in interrupt contexts, we just couldn't use cpu_relax(). But, I could be wrong. Hopefully someone might be able to provide some more information on this. For now I can remove all the comedi_timeout() changes that are used in interrupt contexts. The ones you have pointed out so far are in: pcl812 pcl816 pcl818 dt2814 das1800 Regards, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
