Re: [PATCH] staging: r8188eu: Fix typo in USB_DEVICE list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/02/2014 03:26 PM, Greg KH wrote:
On Sun, Feb 02, 2014 at 02:07:06PM -0600, Larry Finger wrote:
There is a typo in the device list that interchanges the vendor and
product codes for one of the entries.

Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
---
  drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 0a341d6..e9e3c76 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
@@ -53,7 +53,7 @@ static struct usb_device_id rtw_usb_id_tbl[] = {
  	{USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */
  	/*=== Customer ID ===*/
  	/****** 8188EUS ********/
-	{USB_DEVICE(0x8179, 0x07B8)}, /* Abocom - Abocom */
+	{USB_DEVICE(0x07bb, 0x8179)}, /* Abocom - Abocom */

Becides the b8 -> bb issue, are you sure this is correct?  I've seen
lots of USB devices that got this backwards (vendor id in the product id
place), so it wouldn't be the first time it's happened.

The listing at http://www.linux-usb.org/usb.ids shows that the vendor code for AboCom Systems Inc is 0x07b8. Although it does not show a device id of 0x8179, I'm pretty sure that this listing has reversed the two entries.

Larry


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux