drivers:staging:dgnc:dpacompat.h- removed following checkpatch.pl reported warnings sccc@ubuntu:~/lk/rc/linux$ ./scripts/checkpatch.pl --terse --file drivers/staging/dgnc/dpacompat.h drivers/staging/dgnc/dpacompat.h:109: ERROR: Macros with complex values should be enclosed in parenthesis drivers/staging/dgnc/dpacompat.h:110: ERROR: Macros with complex values should be enclosed in parenthesis drivers/staging/dgnc/dpacompat.h:111: ERROR: Macros with complex values should be enclosed in parenthesis drivers/staging/dgnc/dpacompat.h:114: WARNING: line over 80 characters drivers/staging/dgnc/dpacompat.h:114: ERROR: Macros with complex values should be enclosed in parenthesis drivers/staging/dgnc/dpacompat.h:115: WARNING: line over 80 characters drivers/staging/dgnc/dpacompat.h:115: ERROR: Macros with complex values should be enclosed in parenthesis total: 5 errors, 2 warnings, 115 lines checked Signed-off-by: Avinash Kumar <avi.kp.137@xxxxxxxxx> --- drivers/staging/dgnc/dpacompat.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/dgnc/dpacompat.h b/drivers/staging/dgnc/dpacompat.h index f96963b..b451c10 100644 --- a/drivers/staging/dgnc/dpacompat.h +++ b/drivers/staging/dgnc/dpacompat.h @@ -24,7 +24,7 @@ * This structure holds data needed for the intelligent <--> nonintelligent * DPA translation */ - struct ni_info { +struct ni_info { int board; int channel; int dtr; @@ -51,7 +51,7 @@ #define RW_READ 1 #define RW_WRITE 2 -#define DIGI_KME ('e'<<8) | 98 /* Read/Write Host */ +#define DIGI_KME (('e'<<8) | 98) /* Read/Write Host */ #define SUBTYPE 0007 #define T_PCXI 0000 @@ -106,10 +106,10 @@ /* Ioctls needed for dpa operation */ -#define DIGI_GETDD ('d'<<8) | 248 /* get driver info */ -#define DIGI_GETBD ('d'<<8) | 249 /* get board info */ -#define DIGI_GET_NI_INFO ('d'<<8) | 250 /* nonintelligent state snfo */ +#define DIGI_GETDD (('d'<<8) | 248) /* get driver info */ +#define DIGI_GETBD (('d'<<8) | 249) /* get board info */ +#define DIGI_GET_NI_INFO (('d'<<8) | 250) /* nonintelligent state snfo */ /* Other special ioctls */ -#define DIGI_TIMERIRQ ('d'<<8) | 251 /* Enable/disable RS_TIMER use */ -#define DIGI_LOOPBACK ('d'<<8) | 252 /* Enable/disable UART internal loopback */ +#define DIGI_TIMERIRQ (('d'<<8) | 251)/* Enable/disable RS_TIMER use*/ +#define DIGI_LOOPBACK (('d'<<8) | 252)/* Enable/disable UART internal loopback*/ -- 1.7.9.5 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel