Re: [PATCH 3/4] staging: lustre: libcfs_debug.h: remove extra blank lines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 14, 2014 at 12:43:58AM +0000, Dilger, Andreas wrote:
> On 2014/01/13, 6:41 AM, "Salym Senyonga" <salymsash@xxxxxxxxx> wrote:
> 
> >This patch removes consecutive blank lines.
> 
> ... but it doesn't leave a single blank line in those places, and in two
> cases also appears to remove a single blank line.
> 

Huh, what?  The rule is that you can't have two blank lines in a row so
this patch is ok.

> To be honest, I'd rather not see minor whitespace-only changes like this
> one,
> since it makes it harder to merge other patches and doesn't really do much
> to improve the readability of this code.
> 

This code is in staging.  Coding style changes are the entire point of
being in staging.  Even if it weren't in staging, in linux we do minor
cleanups all the time.  That's what makes it linux.

regards,
dan carpenter


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux