Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 13, 2014 at 11:19:15PM +0000, Joe Borg wrote:
> Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo
> *bar' in the parameters of function munge_data().

Ok, real minor nits here, but I'd like you to make them for future
patches as it makes my life easier, and I don't like to edit patches by
hand, as I don't scale very well.

Your subject should be:
	[PATCH] staging: comedi: das1800: fix for * bar to be foo *bar

you need to add the driver subsystem, and specific area and driver.  And
no kernel drivers are ALL CAPS, so that should never be used.

I've taken this patch as-is, but in the future please try to do this.

Oh, one more thing:

> Signed-off-by Joe Borg <cyborg101010@xxxxxxxxx>

You forgot a ':' here :)

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux