On Mon, Jan 13, 2014 at 08:41:40PM +0100, Pol Eyschen wrote:
> From: Pol Eyschen <poleyschen@xxxxxxxxxxx>
>
> All comments fixed to match the kernel coding style.
>
> Signed-off-by: Pol Eyschen <poleyschen@xxxxxxxxx>
> ---
This patch doesn't apply to my staging-next branch. Are you making your
changes to the staging-next branch of
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git?
> drivers/staging/ced1401/ced_ioc.c | 382 ++++++++++++++++++++++++-------------
> 1 file changed, 249 insertions(+), 133 deletions(-)
>
> diff --git a/drivers/staging/ced1401/ced_ioc.c b/drivers/staging/ced1401/ced_ioc.c
> index 62efd74..e5172cb 100644
> --- a/drivers/staging/ced1401/ced_ioc.c
> +++ b/drivers/staging/ced1401/ced_ioc.c
> @@ -41,7 +41,8 @@ static void FlushOutBuff(DEVICE_EXTENSION *pdx)
> {
> dev_dbg(&pdx->interface->dev, "%s currentState=%d", __func__,
> pdx->sCurrentState);
> - if (pdx->sCurrentState == U14ERR_TIME) /* Do nothing if hardware in trouble */
> + if (pdx->sCurrentState == U14ERR_TIME)
> + /* Do nothing if hardware in trouble */
> return;
Putting a comment after a single line 'if' and before the statement is
not the norm and can be confusing. Please don't do it.
Also, quite a few of the comments you're moving around here look to be
unecessary, and can probably be deleted.
Mark
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
