Re: [PATCH v4 1/1] staging: fpgaboot: Xilinx FPGA firmware download driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 11, 2014 at 12:51:28PM -0800, Greg KH wrote:
> On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote:
> > This driver downloads Xilinx FPGA firmware using gpio pins.
> > It loads Xilinx FPGA bitstream format firmware image and
> > program the Xilinx FPGA using SelectMAP (parallel) mode.
> > 
> > Signed-off-by: Insop Song <insop.song@xxxxxxxxxxxxx>
> 
> This patch breaks the build on my machine, please be more careful:
> 
> drivers/staging/gs_fpgaboot/gs_fpgaboot.c:30:28: fatal error: include/asm/io.h: No such file or directory
>  #include <include/asm/io.h>
> 
> Please fix this up, test it, and resend.

Also, while you are fixing things up, please just remove the character
device node from the driver, you aren't doing anything with it, so it's
not needed.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux