[staging:staging-next 479/499] drivers/staging/rtl8188eu/core/rtw_cmd.c:411 rtw_cmd_thread() error: double unlock 'sem:&pcmdpriv->terminate_cmdthread_sema'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Larry,

FYI, there are new smatch warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-next
head:   55323187f86f6ab39ee79eb4248b2efe29a464f2
commit: 2ca4ab5324062e70393e9a37a8db1ea94d6e2f99 [479/499] staging: r8188eu: Remove wrappers _rtw_free_sema, _rtw_up_sema, and _rtw_mutex_init

New smatch warnings:
drivers/staging/rtl8188eu/core/rtw_cmd.c:411 rtw_cmd_thread() error: double unlock 'sem:&pcmdpriv->terminate_cmdthread_sema'

Old smatch warnings:
drivers/staging/rtl8188eu/core/rtw_cmd.c:2100 c2h_wk_callback() error: we previously assumed 'c2h_evt' could be null (see line 2090)

git remote add staging git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
git remote update staging
git checkout 2ca4ab5324062e70393e9a37a8db1ea94d6e2f99
vim +411 drivers/staging/rtl8188eu/core/rtw_cmd.c

9a7fe54d Larry Finger 2013-08-21  395  
9a7fe54d Larry Finger 2013-08-21  396  		goto _next;
9a7fe54d Larry Finger 2013-08-21  397  	}
9a7fe54d Larry Finger 2013-08-21  398  	pcmdpriv->cmdthd_running = false;
9a7fe54d Larry Finger 2013-08-21  399  
9a7fe54d Larry Finger 2013-08-21  400  	/*  free all cmd_obj resources */
9a7fe54d Larry Finger 2013-08-21  401  	do {
9a7fe54d Larry Finger 2013-08-21  402  		pcmd = rtw_dequeue_cmd(pcmdpriv);
9a7fe54d Larry Finger 2013-08-21  403  		if (pcmd == NULL)
9a7fe54d Larry Finger 2013-08-21  404  			break;
9a7fe54d Larry Finger 2013-08-21  405  
9a7fe54d Larry Finger 2013-08-21  406  		/* DBG_88E("%s: leaving... drop cmdcode:%u\n", __func__, pcmd->cmdcode); */
9a7fe54d Larry Finger 2013-08-21  407  
9a7fe54d Larry Finger 2013-08-21  408  		rtw_free_cmd_obj(pcmd);
9a7fe54d Larry Finger 2013-08-21  409  	} while (1);
9a7fe54d Larry Finger 2013-08-21  410  
2ca4ab53 Larry Finger 2013-12-22 @411  	up(&pcmdpriv->terminate_cmdthread_sema);
9a7fe54d Larry Finger 2013-08-21  412  
9a7fe54d Larry Finger 2013-08-21  413  _func_exit_;
9a7fe54d Larry Finger 2013-08-21  414  
dfa5e81e Larry Finger 2013-12-19  415  	complete_and_exit(NULL, 0);
9a7fe54d Larry Finger 2013-08-21  416  }
9a7fe54d Larry Finger 2013-08-21  417  
9a7fe54d Larry Finger 2013-08-21  418  u8 rtw_setstandby_cmd(struct adapter *padapter, uint action)
9a7fe54d Larry Finger 2013-08-21  419  {

---
0-DAY kernel build testing backend              Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux