Re: [PATCH] Staging: comedi: fixed style issue Fixed a coding style issue Signed-off-by: Aruna Hewapathirane <aruna.hewapathirane@xxxxxxxxx>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



my apologies, it's my very first patch :-)

On Mon, Jan 6, 2014 at 4:09 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> Changelog mangled.  You need a blank after the subject.
>
> On Mon, Jan 06, 2014 at 04:00:39AM -0500, Aruna-Hewapathirane wrote:
>> ---
>>  drivers/staging/comedi/drivers/ke_counter.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/ke_counter.c b/drivers/staging/comedi/drivers/ke_counter.c
>> index 15589f6..cebf818 100644
>> --- a/drivers/staging/comedi/drivers/ke_counter.c
>> +++ b/drivers/staging/comedi/drivers/ke_counter.c
>> @@ -105,7 +105,7 @@ static int cnt_auto_attach(struct comedi_device *dev,
>>       dev->read_subdev = s;
>>       s->type = COMEDI_SUBD_COUNTER;
>> -     s->subdev_flags = SDF_READABLE /* | SDF_COMMON */ ;
>> +     s->subdev_flags = SDF_READABLE /* | SDF_COMMON */;
>>       s->n_chan = 3;
>>       s->maxdata = 0x00ffffff;
>>       s->insn_read = cnt_rinsn;
>> @@ -120,7 +120,7 @@ static int cnt_auto_attach(struct comedi_device *dev,
>>       outb(0, dev->iobase + 0x40);
>>       dev_info(dev->class_dev, "%s: %s attached\n",
>> -             dev->driver->driver_name, dev->board_name);
>> +     dev->driver->driver_name, dev->board_name);
>
> Nope.  The original was better.
>
> regards,
> dan carpenter
>
>>       return 0;
>>  }
>> --
>> 1.7.0.4
>>
>> _______________________________________________
>> devel mailing list
>> devel@xxxxxxxxxxxxxxxxxxxxxx
>> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



-- 
Aruna Hewapathirane
Consultant/Trainer
Phone : 647-709-9269
Website: Open Source Solutions
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux