Re: [PATCH 2/3] Staging rtl8192e: Fixing checkpatch error in rtllib_debug.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jan 05, 2014 at 01:25:36PM +0100, Andreas Frembs wrote:
> In rtllib_debug.h we fixed the following checkpatch error:
> 	ERROR: Macros with complex values should be enclosed in parenthesis
> 
> We fixed this with a do {} while (0), because otherwise the compiler complained.
> 
> Signed-off-by: Andreas Frembs <andreas.frembs@xxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Matthias Schoepe <matthias.schoepe@xxxxxxxxxxxxxxxxxxxxxxx>

It would be better to replace these with WARN_ON().  I haven't looked
but I also suspect that some of these asserts might be bogus and should
be removed.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux