On Sat, Dec 28, 2013 at 03:13:52AM -0600, Chase Southwood wrote: > From: Chase Southwood <chase.southwood@xxxxxxxxx> We get this from your email. It's not needed unless you are forwarding a patch from someone else. > > This is a patch for pcmmio.c that changes several printk() calls to dev_dbg() or dev_err() to fix checkpatch.pl warnings. Patched from 3.13-rc5. Line wrap the description at 72 characters. Don't put "Patched from 3.13-rc5." in the patch description because we don't want it to be a part of the permanent change description. Also you should be doing these against linux-next anyway. > > Signed-off-by: Chase Southwood <chase.southwood@xxxxxxxxx> > --- > drivers/staging/comedi/drivers/pcmmio.c | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/pcmmio.c b/drivers/staging/comedi/drivers/pcmmio.c > index 14cee3a..8a567c9 100644 > --- a/drivers/staging/comedi/drivers/pcmmio.c > +++ b/drivers/staging/comedi/drivers/pcmmio.c > @@ -252,7 +252,8 @@ static int pcmmio_dio_insn_bits(struct comedi_device *dev, > > #ifdef DAMMIT_ITS_BROKEN > /* DEBUG */ > - printk(KERN_DEBUG "write mask: %08x data: %08x\n", data[0], data[1]); > + dev_dbg(dev->class_dev, "write mask: %08x data: %08x\n", > + data[0], data[1]); Just delete everything to do with DAMMIT_ITS_BROKEN. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
