Hi! > From: Ivaylo Dimitrov <freemangordon@xxxxxx> > > Use upstream hashtable implementation instead of generic code > > Signed-off-by: Ivaylo Dimitrov <freemangordon@xxxxxx> > @@ -991,8 +989,11 @@ static struct dynload_symbol *dbll_add_to_symbol_table(struct dynamic_loader_sym > sym_ptr = > (struct dbll_symbol *)gh_insert(lib->sym_tab, (void *)name, > (void *)&symbol); > - if (sym_ptr == NULL) > + if (IS_ERR(sym_ptr)) > + { You want this { to go to the previous line. Otherwise looks good, Reviewed-by: Pavel Machek <pavel@xxxxxx> Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel