On Sun, Dec 22, 2013 at 12:19:52PM +0800, Liu Ying wrote: > This patch declares the function of_get_tve_mode > as a static one to fix this sparse warning: > drivers/staging/imx-drm/imx-tve.c:563:11: warning: \ > symbol 'of_get_tve_mode' was not declared. \ > Should it be static? > > Signed-off-by: Liu Ying <Ying.Liu@xxxxxxxxxxxxx> Acked-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > --- > drivers/staging/imx-drm/imx-tve.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/imx-drm/imx-tve.c b/drivers/staging/imx-drm/imx-tve.c > index 2c44fef..9abc7ca 100644 > --- a/drivers/staging/imx-drm/imx-tve.c > +++ b/drivers/staging/imx-drm/imx-tve.c > @@ -560,7 +560,7 @@ static const char *imx_tve_modes[] = { > [TVE_MODE_VGA] = "vga", > }; > > -const int of_get_tve_mode(struct device_node *np) > +static const int of_get_tve_mode(struct device_node *np) > { > const char *bm; > int ret, i; > -- > 1.7.9.5 > > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel