Hi Dan,
On Sat, Dec 21, 2013 at 2:00 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Fri, Dec 20, 2013 at 08:54:30PM +0530, Gokulnath A wrote:
>> From: Gokulnath Avanashilingam <Gokulnath.Avanashilingam@xxxxxxxxxxxx>
>
> No need. This should come from your email.
>
>>
>> Fixed all the line over 80 characters warning found by
>> checkpatch.pl script.
>>
>> Signed-off-by: Gokulnath Avanashilingam <Gokulnath.Avanashilingam@xxxxxxxxxxxx>
>
Sorry, I used gmail to send patch because of firewall settings.
I will change it in the next patch.
> This doesn't match the email you are using so we can't verify it.
>
>> - if (Adapter->ulPowerSaveMode == DEVICE_POWERSAVE_MODE_AS_MANUAL_CLOCK_GATING) {
>> + if (Adapter->ulPowerSaveMode ==
>> + DEVICE_POWERSAVE_MODE_AS_MANUAL_CLOCK_GATING) {
>> uiRegRead = 0x00000000 ;
>
> The alignment here should be:
>
> if (Adapter->ulPowerSaveMode ==
> DEVICE_POWERSAVE_MODE_AS_MANUAL_CLOCK_GATING) {
> uiRegRead = 0x00000000;
>
> Notice how the 'A' and the 'D' are aligned? I used space characters to
> make that work. Btw, hopefully this will fit on one line after we clean
> up the variable names.
>
Ok, I will modify and take care of it the next series.
>>
>> - bytes = rdmalt(Adapter, DEVICE_INT_OUT_EP_REG1, &uiRegVal, sizeof(uiRegVal));
>> + bytes = rdmalt(Adapter,
>> + DEVICE_INT_OUT_EP_REG1,
>> + &uiRegVal, sizeof(uiRegVal));
>> if (bytes < 0) {
>
> The alignment here should be:
>
> bytes = rdmalt(Adapter, DEVICE_INT_OUT_EP_REG1, &uiRegVal,
> sizeof(uiRegVal));
> if (bytes < 0) {
>
> The 'A' and the 's' character are lined up.
Thanks for the review comments. I will modify all these
and send a new patch.
>
> regards,
> dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
