Hello Michael,
On Fri, Dec 20, 2013 at 7:21 PM, Michael Hoefler
<michael.hoefler@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> This patch addresses several problems in bypass.c found by checkpatch.
> Furthermore it removes/adds some empty lines to make the code more readable.
>
> The following problems are fixed:
> - line over 80 characters
> - space after logical operator !
> - spaces instead of tabs
> - missing empty line after local declarations
> - empty line after {
>
Please do one thing per patch, As Greg suggested for me in previous mail
conversations. Here you could have at least 3 or 4 patches.
For example, first patch would be a fix for line over 80 characters,
followed by the other problems as mentioned above by you.
> The empty line issues were not discovered by checkpatch but in my opinion these
> changes make perfect sense in terms of readability.
>
> Signed-off-by: Michael Hoefler <michael.hoefler@xxxxxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Christoph Kohl <christoph.kohl@xxxxxxxxxxx>
> ---
> drivers/staging/silicom/bypasslib/bypass.c | 111 ++++++++++++++++-------------
> 1 file changed, 61 insertions(+), 50 deletions(-)
>
1.8.1.2
>
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
