On Thu, 19 Dec 2013, David Herrmann wrote: > > diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c > > index 253fe23..81eacd3 100644 > > --- a/drivers/hid/hid-core.c > > +++ b/drivers/hid/hid-core.c > > @@ -1334,7 +1334,7 @@ int hid_report_raw_event(struct hid_device *hid, int type, u8 *data, int size, > > csize--; > > } > > > > - rsize = ((report->size - 1) >> 3) + 1; > > + rsize = ((report->size - 1) >> 3) + 1 + (report->id > 0) + 7; > > Isn't "report->id" already covered by "if (report_enum->numbered)" > above? The test for "id > 0" won't work here as in this case > "report_enum->numbered" must already be set to true by the hid-desc > parser, doesn't it? Right, that one is not correct here, thanks. > Where exactly did you get the +7 from? Please see commit (the one I am not really proud of) 27ce405039bfe6d3. -- Jiri Kosina SUSE Labs _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
